Re: log --graph --first-parent weirdness

From: Adam Simpkins <adam@adamsimpkins.net>
Date: Jun 5, 2008, 09:28 UTC
Message-ID: <20080605092812.GA14116@adamsimpkins.net>
In-Reply-To: <7v1w3dxeh9.fsf@gitster.siamese.dyndns.org>

On Wed, Jun 04, 2008 at 11:05:38AM -0700, Junio C Hamano wrote:

> 
> I'd really suggest changing the "M" and use "*" everywhere.

That's fine with me.  Here's a simple patch to change the behavior.

-- >8 -- "git log --graph": print '*' for all commits, including merges

Previously, merge commits were printed with 'M' instead of '*'. This had the potential to confuse users when not all parents of the merge commit were included in the log output.

As Junio has pointed out, merge commits can almost always be easily identified from the log message, anyway.

Signed-off-by: Adam Simpkins <adam@adamsimpkins.net>
---
 graph.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/graph.c b/graph.c
index edfab2d..c50adcd 100644
--- a/graph.c
+++ b/graph.c
@@ -638,20 +638,6 @@ static void graph_output_commit_char(struct git_graph *graph, struct strbuf *sb)
 	}
 
 	/*
-	 * Print 'M' for merge commits
-	 *
-	 * Note that we don't check graph->num_parents to determine if the
-	 * commit is a merge, since that only tracks the number of
-	 * "interesting" parents.  We want to print 'M' for merge commits
-	 * even if they have less than 2 interesting parents.
-	 */
-	if (graph->commit->parents != NULL &&
-	    graph->commit->parents->next != NULL) {
-		strbuf_addch(sb, 'M');
-		return;
-	}
-
-	/*
 	 * Print '*' in all other cases
 	 */
 	strbuf_addch(sb, '*');

-- 
1.5.6.rc1.13.g14be6