Re: [PATCH] t9600: allow testing with cvsps 2.2, including beta versions

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 15, 2008, 00:31 UTC
Message-ID: <7v1w1wdm37.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080715002019.5337.81984.stgit@dv.roinet.com>

Pavel Roskin <proski@gnu.org> writes:

> Don't assume that unsupported versions are too old, they may be too new.

Excuse me, but we never assumed such.

Neither too old nor too new ones are proven to work with us yet, so we cannot be call them supported.

Let's apply your patch and see how well version 2.2 fares.

Thanks.

Show 10 quoted lines

> diff --git a/t/t9600-cvsimport.sh b/t/t9600-cvsimport.sh
> index 655f882..f92b47a 100755
> --- a/t/t9600-cvsimport.sh
> +++ b/t/t9600-cvsimport.sh
> @@ -20,13 +20,15 @@ cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
>  case "$cvsps_version" in
>  2.1)
>  	;;
> +2.2*)
> +	;;

Hmm, I would have written:

	case "$..." in
        2.1 | 2.2 )

Is the reason why you have the asterisk there because the beta one claims "2.2beta" or something (I am not suggesting to tighten the match, just asking for information)?