threads / patch / 14456

patcht9600: allow testing with cvsps 2.2, including beta versions

Subject: [PATCH] t9600: allow testing with cvsps 2.2, including beta versions

## tl;dr

4 messages between Jul 15, 2008 and Jul 16, 2008. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Pavel Roskin· Jul 15, 2008, 00:20 UTC · lore

Don't assume that unsupported versions are too old, they may be too new.

Signed-off-by: Pavel Roskin <proski@gnu.org>
---

 t/t9600-cvsimport.sh |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Show changes to t/t9600-cvsimport.sh +3 −1

diff --git a/t/t9600-cvsimport.sh b/t/t9600-cvsimport.sh
index 655f882..f92b47a 100755
--- a/t/t9600-cvsimport.sh
+++ b/t/t9600-cvsimport.sh
@@ -20,13 +20,15 @@ cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
 case "$cvsps_version" in
 2.1)
 	;;
+2.2*)
+	;;
 '')
 	say 'skipping cvsimport tests, cvsps not found'
 	test_done
 	exit
 	;;
 *)
-	say 'skipping cvsimport tests, cvsps too old'
+	say 'skipping cvsimport tests, unsupported cvsps version'
 	test_done
 	exit
 	;;

Junio C Hamano· Jul 15, 2008, 00:31 UTC · re: Pavel Roskin · lore

Re: [PATCH] t9600: allow testing with cvsps 2.2, including beta versions

Pavel Roskin <proski@gnu.org> writes:

> Don't assume that unsupported versions are too old, they may be too new.

Excuse me, but we never assumed such.

Neither too old nor too new ones are proven to work with us yet, so we cannot be call them supported.

Let's apply your patch and see how well version 2.2 fares.

Thanks.

Show 10 quoted lines

> diff --git a/t/t9600-cvsimport.sh b/t/t9600-cvsimport.sh
> index 655f882..f92b47a 100755
> --- a/t/t9600-cvsimport.sh
> +++ b/t/t9600-cvsimport.sh
> @@ -20,13 +20,15 @@ cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps version //p'`
>  case "$cvsps_version" in
>  2.1)
>  	;;
> +2.2*)
> +	;;

Hmm, I would have written:

	case "$..." in
        2.1 | 2.2 )

Is the reason why you have the asterisk there because the beta one claims "2.2beta" or something (I am not suggesting to tighten the match, just asking for information)?

Pavel Roskin· Jul 15, 2008, 00:51 UTC · re: Junio C Hamano · lore

Re: [PATCH] t9600: allow testing with cvsps 2.2, including beta versions

Quoting Junio C Hamano <gitster@pobox.com>:

Show 8 quoted lines

> Pavel Roskin <proski@gnu.org> writes:
>
>> Don't assume that unsupported versions are too old, they may be too new.
>
> Excuse me, but we never assumed such.
>
> Neither too old nor too new ones are proven to work with us yet, so we
> cannot be call them supported.

The message was "skipping cvsimport tests, cvsps too old" so the assumption was there.

Show 20 quoted lines

> Let's apply your patch and see how well version 2.2 fares.
>
> Thanks.
>
>> diff --git a/t/t9600-cvsimport.sh b/t/t9600-cvsimport.sh
>> index 655f882..f92b47a 100755
>> --- a/t/t9600-cvsimport.sh
>> +++ b/t/t9600-cvsimport.sh
>> @@ -20,13 +20,15 @@ cvsps_version=`cvsps -h 2>&1 | sed -ne 's/cvsps  
>>  version //p'`
>>  case "$cvsps_version" in
>>  2.1)
>>  	;;
>> +2.2*)
>> +	;;
>
> Hmm, I would have written:
>
> 	case "$..." in
>         2.1 | 2.2 )

Fine with me, but please allow for extra specifiers.

> Is the reason why you have the asterisk there because the beta one claims
> "2.2beta" or something (I am not suggesting to tighten the match, just
> asking for information)?

It's cvsps 2.2b1 from Fedora Development (cvsps-2.2-0.1.b1.fc10.x86_64)

$ cvsps -h 2>&1 | grep version cvsps version 2.2b1

-- 
Regards,
Pavel Roskin

Jeff King· Jul 16, 2008, 07:11 UTC · re: Pavel Roskin · lore

Re: [PATCH] t9600: allow testing with cvsps 2.2, including beta versions

On Mon, Jul 14, 2008 at 08:51:14PM -0400, Pavel Roskin wrote:

Show 7 quoted lines

> > Excuse me, but we never assumed such.
> >
> > Neither too old nor too new ones are proven to work with us yet, so we
> > cannot be call them supported.
> 
> The message was "skipping cvsimport tests, cvsps too old" so the  
> assumption was there.

Heh, you can blame me for making that assumption. But at the time I wrote it, I think cvsps development had stagnated, so there weren't new versions. :)

-Peff