Re: [PATCH] Make 'diff C^!' show the same diff as 'show C'

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 20, 2009, 23:01 UTC
Message-ID: <7v1vn6ozso.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090820223424.GA5843@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 17 quoted lines

> On Thu, Aug 20, 2009 at 03:25:16PM -0700, Junio C Hamano wrote:
>
>> Thomas Rast <trast@student.ethz.ch> writes:
>> 
>> > Ideally, we'd like 'git diff C^!' to show the same diff that 'git show C'
>> > does (with log.showroot enabled).  This gives easy access to a readable
>> > diff for the commit, irrespective of how many parents it has and without
>> > any trickery to remove the commit message from the git-show output.
>> 
>> Not interested yet, as the "git show" discussion is not convincing at all.
>> 
>> Is the message annoying enough to warrant this change?
>
> I thought the same thing when I saw his message, but reading further,
> the current output is nonsensical. So if not this patch, we should
> probably at least complain about bogus input and die (though if it is
> easy to make it work, why not...).

Ok.