Re: [PATCH] Make 'diff C^!' show the same diff as 'show C'
- From
Jeff King <peff@peff.net>
- Date
- Aug 20, 2009, 22:34 UTC
- Message-ID
- <20090820223424.GA5843@coredump.intra.peff.net>
- In-Reply-To
- <7vab1up1gz.fsf@alter.siamese.dyndns.org>
On Thu, Aug 20, 2009 at 03:25:16PM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> Thomas Rast <trast@student.ethz.ch> writes: > > > Ideally, we'd like 'git diff C^!' to show the same diff that 'git show C' > > does (with log.showroot enabled). This gives easy access to a readable > > diff for the commit, irrespective of how many parents it has and without > > any trickery to remove the commit message from the git-show output. > > Not interested yet, as the "git show" discussion is not convincing at all. > > Is the message annoying enough to warrant this change?
I thought the same thing when I saw his message, but reading further, the current output is nonsensical. So if not this patch, we should probably at least complain about bogus input and die (though if it is easy to make it work, why not...).
-Peff