Re: [BUG] 'add -u' doesn't work from untracked subdir

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 7, 2009, 05:07 UTC
Message-ID: <7v1vmj9wcq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090907090713.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

[jc: sometimes but not always your messages have looooooooooooooong lines. please line-wrap for readability. I learned to type W Q so often I do not complain but other people would find them irritating.]

> The default behavior for 'git-grep' has already been discussed in
> length, and I don't think it is likely to change. See
>
>   http://thread.gmane.org/gmane.comp.version-control.git/111519/focus=111717

Interesting.

The first message in that thread lists things we have scheduled for 1.7.0 but it has another item. It is an off-topic for the thread, but we might want to resurrect the "core.quotepath defaults to false" proposal, before it gets too late for 1.7.0.

As to "grep", I am open to the proposal to make git commands consistent by letting them operate on everything when no path argument is given, if grep is really the single odd-man out remaining after changing the "add -u" and "add -A" to work on the whole tree from subdirectories when given no paths.

Show 9 quoted lines

> The original design for the other two in your list was to be a whole
> tree operation. This commit broke it.
>
>   2ed2c22 "git-add -u paths... now works from subdirectory".
> ...
> I think it is a good idea to fix this as an old regression in the maint
> branch. You don't have to introduce "git add -a". In fact the -a option
> was explicitly rejected when "git add -A" option was added with this
> commit.

Geez, you are good at digging things up.

It is very tempting to follow the suggestion above, but I suspect that, even though it may be a regression from historical point of view, some people who are used to the current behaviour may look at the corrected one as a regression. We've had the change by 2ed2c22 for a long time.

I dunno.