Re: [PATCH 0/2] fix weird git --paginate behavior

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 6, 2010, 07:17 UTC
Message-ID: <7v1vetjbi2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100406040145.GA30403@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 11 quoted lines

> Nguyễn Thái Ngọc Duy wrote:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>
> Thanks for posting this series.  I had not read it in full before.
>
> The series is very long and it is hard to make certain it does not
> introduce regressions.  Here is my idea for working around this: the
> idea is to grab patches from the series to form short, independently
> justifiable mini-series.

Thanks for trying out your idea.

I've been having trouble reviewing this series. I can read bits and pieces and find things that I mostly agree with, or things that I find questionable. But in either case, I cannot be sure about my judgement without having a clear idea of where the series is trying to go upfront.

While a re-roll will certainly give us a chance to review the series "cover-to-cover", it would make it much easier to swallow if this can be split into independently digestable bite-sized pieces. I am somewhat skeptical if a major part of the series will become that smaller, though...