git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] fix weird git --paginate behavior

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 6, 2010, 04:01 UTC
Message-ID
<20100406040145.GA30403@progeny.tock>
In-Reply-To
<1270492888-26589-44-git-send-email-pclouds@gmail.com>
Hi,
Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Thanks for posting this series.  I had not read it in full before.

The series is very long and it is hard to make certain it does not introduce regressions. Here is my idea for working around this: the idea is to grab patches from the series to form short, independently justifiable mini-series. Once most of the functional changes are merged, it should be a lot easier to evaluate the core code change that makes setup more brittle (which I like a lot).

What do you think?  Is it worth the trouble?

Here’s an example mini-series. Patch 1 adds a test case for some weird git -p behavior. Patch 2 fixes it.

Jonathan Nieder (1):
  t7006: test an edge case for git --paginate
Nguyễn Thái Ngọc Duy (1):
  builtins: do not commit pager choice early
 git.c            |    1 -
 t/t7006-pager.sh |   32 ++++++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 1 deletions(-)
Previous: Nguyễn Thái Ngọc DuyNext: Jonathan Nieder
Message 45 of 50 in “nd/setup update”
  1. 00/43 nd/setup updateNguyễn Thái Ngọc Duy, Apr 5, 2010
  2. 01/43 builtin: introduce startup_info structNguyễn Thái Ngọc Duy, Apr 5, 2010
  3. 02/43 builtin: Support RUN_SETUP_GENTLY to set up repository early if foundNguyễn Thái Ngọc Duy, Apr 5, 2010
  4. 03/43 config: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  5. 04/43 hash-object: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  6. 05/43 shortlog: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  7. 06/43 grep: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  8. 07/43 builtin: USE_PAGER should not be used without RUN_SETUP*Nguyễn Thái Ngọc Duy, Apr 5, 2010
  9. 08/43 archive: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  10. 09/43 mailinfo: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  11. 10/43 check-ref-format: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  12. 11/43 verify-pack: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  13. 12/43 apply: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  14. 13/43 bundle: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  15. 14/43 diff: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  16. 15/43 help: take note why this command is not applicable for RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  17. 16/43 ls-remote: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  18. 17/43 var: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  19. 18/43 merge-file: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  20. 19/43 worktree setup: calculate prefix even if no worktree is foundNguyễn Thái Ngọc Duy, Apr 5, 2010
  21. 20/43 index-pack: trust the prefix returned by setup_git_directory_gently()Nguyễn Thái Ngọc Duy, Apr 5, 2010
  22. 21/43 index-pack: use RUN_SETUP_GENTLYNguyễn Thái Ngọc Duy, Apr 5, 2010
  23. 22/43 Move enter_repo() to setup.cNguyễn Thái Ngọc Duy, Apr 5, 2010
  24. 23/43 enter_repo(): initialize other variables as setup_git_directory_gently() doesNguyễn Thái Ngọc Duy, Apr 5, 2010
  25. 24/43 rev-parse --git-dir: print relative gitdir correctlyNguyễn Thái Ngọc Duy, Apr 5, 2010
  26. 25/43 worktree setup: call set_git_dir explicitlyNguyễn Thái Ngọc Duy, Apr 5, 2010
  27. 26/43 Add git_config_early()Nguyễn Thái Ngọc Duy, Apr 5, 2010
  28. 27/43 Use git_config_early() instead of git_config() during repo setupNguyễn Thái Ngọc Duy, Apr 5, 2010
  29. 28/43 worktree setup: restore original state when things go wrongNguyễn Thái Ngọc Duy, Apr 5, 2010
  30. 29/43 init/clone: turn on startup->have_repository properlyNguyễn Thái Ngọc Duy, Apr 5, 2010
  31. 30/43 git_config(): do not read .git/config if there is no repositoryNguyễn Thái Ngọc Duy, Apr 5, 2010
  32. 31/43 Do not read .git/info/exclude if there is no repositoryNguyễn Thái Ngọc Duy, Apr 5, 2010
  33. 32/43 Do not read .git/info/attributes if there is no repositoryNguyễn Thái Ngọc Duy, Apr 5, 2010
  34. 33/43 apply: do not check sha1 if there is no repositoryNguyễn Thái Ngọc Duy, Apr 5, 2010
  35. 34/43 config: do not read .git/config if there is no repositoryNguyễn Thái Ngọc Duy, Apr 5, 2010
  36. 35/43 run_builtin(): save "-h" detection result for later useNguyễn Thái Ngọc Duy, Apr 5, 2010
  37. 36/43 builtins: utilize startup_info->help where possibleNguyễn Thái Ngọc Duy, Apr 5, 2010
  38. 37/43 builtins: check for startup_info->help, print and exit earlyNguyễn Thái Ngọc Duy, Apr 5, 2010
  39. 38/43 Allow to undo setup_git_directory_gently() gracefully (and fix alias code)Nguyễn Thái Ngọc Duy, Apr 5, 2010
  40. 39/43 alias: keep repository found while collecting aliases as long as possibleNguyễn Thái Ngọc Duy, Apr 5, 2010
  41. 40/43 Guard unallowed access to repository when it's not set upNguyễn Thái Ngọc Duy, Apr 5, 2010
  42. 41/43 t0001: Add test cases for "git init" with aliasesNguyễn Thái Ngọc Duy, Apr 5, 2010
  43. 42/43 builtins: setup repository before print unknown command errorNguyễn Thái Ngọc Duy, Apr 5, 2010
  44. 43/43 builtins: do not commit pager choice earlyNguyễn Thái Ngọc Duy, Apr 5, 2010
  45. 0/2 fix weird git --paginate behaviorJonathan Nieder, Apr 6, 2010
  46. 1/2 t7006: test core.pager configuration in subdir of toplevelJonathan Nieder, Apr 6, 2010
  47. 2/2 builtins: do not commit pager choice earlyJonathan Nieder, Apr 6, 2010
  48. Jonathan NiederApr 6, 2010
  49. Nguyen Thai Ngoc DuyApr 6, 2010
  50. Junio C HamanoApr 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.