git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git difftool does does not respect current working directory

From
Junio C Hamano <gitster@pobox.com>
Date
May 16, 2011, 05:39 UTC
Message-ID
<7v1uzznr09.fsf@alter.siamese.dyndns.org>
In-Reply-To
<loom.20110514T160931-46@post.gmane.org>
Frédéric Heitzmann  <frederic.heitzmann@gmail.com> writes:
Show 5 quoted lines
> Unfortunately, 'git difftool' does not keep the current working directory while
> launching gvimdiff.
>
> => Is it done on purpose ?
> If not, it is probably a good idea to fix this.
I will not comment on "on purpose?" part, as I do not use difftool myself.
But the right set of questions to ask is not the above, but these:
 - Is it on purpose that difftool runs its diff viewer from the top of the
   working tree?
 - Is there any existing user who depends on that current behaviour?  IOW,
   would anybody suffer if difftool suddenly starts to run the diff viewer
   from the subdirectory that the user started "git difftool" from?

If the answers to both of them are No, then it might be a good idea to change the behaviour.

Previous: Frédéric HeitzmannNext: David Aguilar
Message 2 of 21 in “git difftool does does not respect current working directory”
  1. Frédéric HeitzmannMay 14, 2011
  2. Junio C HamanoMay 16, 2011
  3. David AguilarMay 20, 2011
  4. David AguilarMay 20, 2011
  5. Junio C HamanoMay 20, 2011
  6. David AguilarMay 20, 2011
  7. Frédéric HeitzmannMay 21, 2011
  8. David AguilarMay 22, 2011
  9. Junio C HamanoMay 22, 2011
  10. David AguilarMay 22, 2011
  11. 1/3 setup: Provide GIT_PREFIX to built-insDavid Aguilar, May 22, 2011
  12. 2/3 git: Remove handling for GIT_PREFIXDavid Aguilar, May 22, 2011
  13. 3/3 git-mergetool--lib: Make vimdiff retain the current directoryDavid Aguilar, May 22, 2011
  14. Michael J GruberMay 23, 2011
  15. Junio C HamanoMay 23, 2011
  16. Ævar Arnfjörð BjarmasonMay 23, 2011
  17. David AguilarMay 25, 2011
  18. David AguilarMay 23, 2011
  19. Michael J GruberMay 23, 2011
  20. Junio C HamanoMay 23, 2011
  21. Michael J GruberMay 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.