git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] git-mergetool--lib: Make vimdiff retain the current directory

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
May 23, 2011, 06:36 UTC
Message-ID
<4DDA0069.9010500@drmicha.warpmail.net>
In-Reply-To
<1306058229-93800-3-git-send-email-davvid@gmail.com>
David Aguilar venit, vidit, dixit 22.05.2011 11:57:
Show 50 quoted lines
> When using difftool with vimdiff it can be unexpected that
> the current directory changes to the root of the project.
> Tell vim to chdir to the value of $GIT_PREFIX to fix this.
> 
> Care is taken to quote the variable so that vim expands it.
> This avoids problems when directory names contain spaces.
> 
> Signed-off-by: David Aguilar <davvid@gmail.com>
> Reported-by: Frédéric Heitzmann <frederic.heitzmann@gmail.com>
> ---
>  git-mergetool--lib.sh |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
> index 4db9212..ece6a08 100644
> --- a/git-mergetool--lib.sh
> +++ b/git-mergetool--lib.sh
> @@ -187,7 +187,9 @@ run_merge_tool () {
>  			fi
>  			check_unchanged
>  		else
> +			resolve_git_prefix
>  			"$merge_tool_path" -R -f -d -c "wincmd l" \
> +				-c 'cd $GIT_PREFIX' \
>  				"$LOCAL" "$REMOTE"
>  		fi
>  		;;
> @@ -198,7 +200,9 @@ run_merge_tool () {
>  				"$LOCAL" "$MERGED" "$REMOTE"
>  			check_unchanged
>  		else
> +			resolve_git_prefix
>  			"$merge_tool_path" -R -f -d -c "wincmd l" \
> +				-c 'cd $GIT_PREFIX' \
>  				"$LOCAL" "$REMOTE"
>  		fi
>  		;;
> @@ -437,3 +441,12 @@ get_merge_tool () {
>  	fi
>  	echo "$merge_tool"
>  }
> +
> +resolve_git_prefix() {
> +	# If GIT_PREFIX is empty then we cannot use it in tools
> +	# that expect to be able to chdir() to its value.
> +	if test -z "$GIT_PREFIX"; then
> +		GIT_PREFIX=.
> +		export GIT_PREFIX
> +	fi
> +}

Hmmm. Maybe we should export "." when there is no prefix? Maybe it's not too late to change that aspect of GIT_PREFIX. We went through some iteration back then for !alias.

Michael
Previous: David AguilarNext: Junio C Hamano
Message 14 of 21 in “git difftool does does not respect current working directory”
  1. Frédéric HeitzmannMay 14, 2011
  2. Junio C HamanoMay 16, 2011
  3. David AguilarMay 20, 2011
  4. David AguilarMay 20, 2011
  5. Junio C HamanoMay 20, 2011
  6. David AguilarMay 20, 2011
  7. Frédéric HeitzmannMay 21, 2011
  8. David AguilarMay 22, 2011
  9. Junio C HamanoMay 22, 2011
  10. David AguilarMay 22, 2011
  11. 1/3 setup: Provide GIT_PREFIX to built-insDavid Aguilar, May 22, 2011
  12. 2/3 git: Remove handling for GIT_PREFIXDavid Aguilar, May 22, 2011
  13. 3/3 git-mergetool--lib: Make vimdiff retain the current directoryDavid Aguilar, May 22, 2011
  14. Michael J GruberMay 23, 2011
  15. Junio C HamanoMay 23, 2011
  16. Ævar Arnfjörð BjarmasonMay 23, 2011
  17. David AguilarMay 25, 2011
  18. David AguilarMay 23, 2011
  19. Michael J GruberMay 23, 2011
  20. Junio C HamanoMay 23, 2011
  21. Michael J GruberMay 24, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.