Re: [PATCH] git-send-email: Add AUTH LOGIN support

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2011, 23:09 UTC
Message-ID: <7v1uwh0zj4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1313716585.11178.2.camel@Joe-Laptop>

Joe Perches <joe@perches.com> writes:

Show 12 quoted lines

> On Fri, 2011-08-05 at 22:21 -0700, Joe Perches wrote:
>> 
>> I needed something now.
>> 
>> You are right but I believe it would take too long
>> to get updates to Net::SMTP in place. Doing this
>> admitted ugliness in git-send-email works for me and
>> seems to me to be appropriate for now.
>> 
>> I looked, there isn't a method to force a particular
>> AUTH type documented.  I also didn't care to rewrite
>> Net::SMTP right now.  This "works for me"...

Good for you ;-)

>> > It probably is not as simple as installing Authen::SASL::*::LOGIN, but
>> > still...
>
> I think my patch should be applied until Net::SMTP is updated.

And you already have applied to your copy, no?

I understand you needed something _now_ and that is why you wrote it, but the thing is, I don't need the ugliness nor an ability to force AUTH LOGIN right now, so I do not necessarily agree with you that the patch _should_ be applied to my tree.