Re: [PATCH] send-email: auth plain/login fix

From: Joe Perches <joe@perches.com>
Date: Sep 26, 2011, 16:59 UTC
Message-ID: <1317056343.14197.2.camel@Joe-Laptop>
In-Reply-To: <7v8vpb5kea.fsf@alter.siamese.dyndns.org>

On Mon, 2011-09-26 at 09:38 -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
> 
> > git send-email was not authenticating properly when communicating over
> > TLS with a server supporting only AUTH PLAIN and AUTH LOGIN. This is
> > e.g. the standard server setup under debian with exim4 and probably
> > everywhere where system accounts are used.
> 
> Now that's a solution that makes me feel less dirty than
> 
>   http://thread.gmane.org/gmane.comp.version-control.git/178818/focus=178824

Dirty is dirty. I don't see this as better or worse really, but thanks Zbigniew for bringing it up again.

It'd be best if Graham Barr, the module author (cc'd), could respond to the issue.

cheers, Joe

Show 6 quoted lines

> even though, by forcing Authen::SASL::Perl to be used bypassing XS and
> Cyrus variants, this _might_ be introducing regression for others. We'll
> find out soon enough if anybody screams ;-)
> 
> I see you already researched previous discussion and have Joe Perches in
> the loop; Thanks.