git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] pack-objects: don't traverse objects unnecessarily

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 12, 2011, 06:55 UTC
Message-ID
<7v1utdrfsf.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAEik5nNmAnPni+rnLm7n5tO7f=LV_1TuTbVqxgjVaoqqaF_Ukw@mail.gmail.com>
Dan McGee <dpmcgee@gmail.com> writes:
Show 6 quoted lines
> On Thu, Oct 27, 2011 at 5:26 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> I am not sure if this produces the identical result that was benchmarked
>> in the original series.
> I was not either when I wrote the patch, and I had hoped to confirm
> the results you showed in the message of 1b4bb16b9ec.

I actually am reasonably sure the result will not be identical, but I also do not think it matters. The differences would appear only for entries that have been filled earlier, which should be a minority.

> unable to figure out how you generated those numbers so I wasn't able
> to do so (and had planned to get back to you to find out how you made
> those tables). Were you able to verify the ordering did not regress?

No; I was hoping you would redo the benchmark using 5f44324 (core: log offset pack data accesses happened, 2011-07-06).

Previous: Dan McGeeNext: Dan McGee
Message 6 of 10 in “pack-objects: mark add_to_write_order() as inline”
  1. 1/4 pack-objects: mark add_to_write_order() as inlineDan McGee, Oct 18, 2011
  2. 2/4 pack-objects: use unsigned int for counter and offset valuesDan McGee, Oct 18, 2011
  3. 3/4 pack-objects: don't traverse objects unnecessarilyDan McGee, Oct 18, 2011
  4. Junio C HamanoOct 27, 2011
  5. Dan McGeeNov 9, 2011
  6. Junio C HamanoNov 12, 2011
  7. Dan McGeeNov 13, 2011
  8. Junio C HamanoNov 14, 2011
  9. 4/4 pack-objects: rewrite add_descendants_to_write_order() iterativelyDan McGee, Oct 18, 2011
  10. Junio C HamanoOct 27, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.