[PATCH 1/4] pack-objects: mark add_to_write_order() as inline
- From
Dan McGee <dpmcgee@gmail.com>
- Date
- Oct 18, 2011, 05:21 UTC
- Message-ID
- <1318915284-6361-1-git-send-email-dpmcgee@gmail.com>
This function is a whole 26 bytes when compiled on x86_64, but is currently invoked over 1.037 billion times when running pack-objects on the Linux kernel git repository. This is hitting the point where micro-optimizations do make a difference, and inlining it only increases the object file size by 38 bytes.
As reported by perf, this dropped task-clock from 84183 to 83373 ms, and total cycles from 223.5 billion to 221.6 billion. Not astronomical, but worth getting for adding one word.
Signed-off-by: Dan McGee <dpmcgee@gmail.com> --- builtin/pack-objects.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 2b18de5..0ab3a3b 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -454,7 +454,7 @@ static int mark_tagged(const char *path, const unsigned char *sha1, int flag, return 0; } -static void add_to_write_order(struct object_entry **wo, +static inline void add_to_write_order(struct object_entry **wo, int *endp, struct object_entry *e) {
-- 1.7.7