git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] api-credentials.txt: add "see also" section

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 5, 2012, 15:12 UTC
Message-ID
<7v1ultrdwi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120605073403.GC25809@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 18 quoted lines
> On Tue, Jun 05, 2012 at 02:59:55AM -0400, Jeff King wrote:
>
>> I wonder if we could even make asciidoc work to convert
>> linkgit:git-config[1] into the right path (i.e., to include the ".."
>> automatically) when we are in the subdir.
>> 
>> I don't really have a sense how powerful asciidoc macros are, but this
>> seems like an obvious case that they should handle.
>
> Here is a simple fix. The Makefile bits are more hacky than I would
> like. It would be really nice if the asciidoc macro could convert "we
> are working on X/Y/Z.html" into "we need ../../ to get to the relative
> base", but I don't think it is that flexible.
>
> We could also replace asciidoc with a wrapper script that does the
> conversion and sets the appropriate attribute. I don't know if it is
> worth the trouble. It's not like we add documentation subdirectories
> very often.

Sorry, but I am not sure what problem is this trying to solve. An API documentation page should only refer to command documentaion pages, and never another API documentation page that is at the same level?

Show 60 quoted lines
> -- >8 --
> Subject: docs: fix cross-directory linkgit references
>
> Most of our documentation is in a single directory, so using
> linkgit:git-config[1] just generates a relative link in the
> same directory. However, this is not the case with the API
> documentation in technical/*, which need to refer to
> git-config from the parent directory.
>
> We can fix this by passing a special prefix attribute when building
> in a subdirectory, and respecting that prefix in our linkgit
> definitions.
>
> We only have to modify the html linkgit definition.  For
> manpages, we can ignore this for two reasons:
>
>   1. we do not generate actual links to the file in
>      manpages, but instead just give the name and section of
>      the linked manpage
>
>   2. we do not currently build manpages for subdirectories,
>      only html
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  Documentation/Makefile      | 2 ++
>  Documentation/asciidoc.conf | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 14286cb..b3693c8 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -280,6 +280,7 @@ technical/api-index.txt: technical/api-index-skel.txt \
>  	technical/api-index.sh $(patsubst %,%.txt,$(API_DOCS))
>  	$(QUIET_GEN)cd technical && '$(SHELL_PATH_SQ)' ./api-index.sh
>  
> +technical/%.html: ASCIIDOC_EXTRA += -a git-relative-html-prefix=../
>  $(patsubst %,%.html,$(API_DOCS) technical/api-index): %.html : %.txt
>  	$(QUIET_ASCIIDOC)$(ASCIIDOC) -b xhtml11 -f asciidoc.conf \
>  		$(ASCIIDOC_EXTRA) -agit_version=$(GIT_VERSION) $*.txt
> @@ -333,6 +334,7 @@ $(patsubst %,%.html,$(ARTICLES)) : %.html : %.txt
>  
>  WEBDOC_DEST = /pub/software/scm/git/docs
>  
> +howto/%.html: ASCIIDOC_EXTRA += git-relative-html-prefix=../
>  $(patsubst %.txt,%.html,$(wildcard howto/*.txt)): %.html : %.txt
>  	$(QUIET_ASCIIDOC)$(RM) $@+ $@ && \
>  	sed -e '1,/^$$/d' $< | $(ASCIIDOC) $(ASCIIDOC_EXTRA) -b xhtml11 - >$@+ && \
> diff --git a/Documentation/asciidoc.conf b/Documentation/asciidoc.conf
> index aea8627..6d06271 100644
> --- a/Documentation/asciidoc.conf
> +++ b/Documentation/asciidoc.conf
> @@ -91,5 +91,5 @@ endif::doctype-manpage[]
>  
>  ifdef::backend-xhtml11[]
>  [linkgit-inlinemacro]
> -<a href="{target}.html">{target}{0?({0})}</a>
> +<a href="{git-relative-html-prefix}{target}.html">{target}{0?({0})}</a>
>  endif::backend-xhtml11[]
Previous: Jeff KingNext: Jeff King
Message 17 of 24 in “Improve credential API documentation”
  1. 0/3 Improve credential API documentationMatthieu Moy, Jun 3, 2012
  2. 1/3 api-credential.txt: show the big picture firstMatthieu Moy, Jun 3, 2012
  3. Jeff KingJun 4, 2012
  4. 2/3 api-credentials.txt: mention credential.helper explicitlyMatthieu Moy, Jun 3, 2012
  5. Jeff KingJun 4, 2012
  6. Matthieu MoyJun 4, 2012
  7. 3/3 api-credentials.txt: add "see also" sectionMatthieu Moy, Jun 3, 2012
  8. Junio C HamanoJun 3, 2012
  9. Matthieu MoyJun 4, 2012
  10. Jeff KingJun 4, 2012
  11. Junio C HamanoJun 4, 2012
  12. Matthieu MoyJun 4, 2012
  13. Jeff KingJun 5, 2012
  14. Jeff KingJun 5, 2012
  15. Matthieu MoyJun 5, 2012
  16. Jeff KingJun 5, 2012
  17. Junio C HamanoJun 5, 2012
  18. Jeff KingJun 5, 2012
  19. Junio C HamanoJun 5, 2012
  20. 1/4 doc: fix xref link from api docs to manual pagesMatthieu Moy, Jun 4, 2012
  21. 2/4 api-credential.txt: show the big picture firstMatthieu Moy, Jun 4, 2012
  22. Jeff KingJun 5, 2012
  23. 3/4 api-credentials.txt: mention credential.helper explicitlyMatthieu Moy, Jun 4, 2012
  24. 4/4 api-credentials.txt: add "see also" sectionMatthieu Moy, Jun 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.