Re: [PATCH 2/3] api-credentials.txt: mention credential.helper explicitly

From: Jeff King <peff@peff.net>
Date: Jun 4, 2012, 11:54 UTC
Message-ID: <20120604115442.GB27676@sigill.intra.peff.net>
In-Reply-To: <1338739804-32167-3-git-send-email-Matthieu.Moy@imag.fr>

On Sun, Jun 03, 2012 at 06:10:03PM +0200, Matthieu Moy wrote:

Show 21 quoted lines

> The name of the configuration variable was mentioned only at the very
> end of the explanation, in a place specific to a specific rule, hence it
> was not very clear what the specification was about.
> 
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
> ---
>  Documentation/technical/api-credentials.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/technical/api-credentials.txt b/Documentation/technical/api-credentials.txt
> index 8804c42..4561469 100644
> --- a/Documentation/technical/api-credentials.txt
> +++ b/Documentation/technical/api-credentials.txt
> @@ -179,7 +179,8 @@ credentials from and to long-term storage (where "long-term" is simply
>  longer than a single git process; e.g., credentials may be stored
>  in-memory for a few minutes, or indefinitely on disk).
>  
> -Each helper is specified by a single string. The string is transformed
> +Each helper is specified by a single string in the configuration
> +variable credential.helper. The string is transformed
>  by git into a command to be executed using these rules:

They may be in other variables, too (like credential.*.helper). I don't know if it is worth making that distinction.

Originally, helpers could also use these specification strings to chain to each other, but in the current implementation, there is no chaining (it was more important when prompting wasn't automatic, so storage helpers would chain to prompting helpers). So I think we can disregard that for now, and they really do just appear in config.

-Peff