Re: [PATCH v2 0/4] a couple of read_key_without_echo() fixes

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Mar 28, 2022, 10:51 UTC
Message-ID: <7ff6c154-4f39-bd66-db89-970e92526ba8@gmail.com>
In-Reply-To: <CAPUEspg1cJC_UwjJFx-jnzWsascY++S3UgM1UCLRcnK_Mv2wOg@mail.gmail.com>

Hi Carlo

On 22/03/2022 20:18, Carlo Arenas wrote:

Show 10 quoted lines

> On Thu, Feb 24, 2022 at 6:30 AM Phillip Wood <phillip.wood123@gmail.com> wrote:
>> That sounds good. I've got a couple more patches based on top of these
>> which hopefully fix the remaining problems (notably the macos poll()
>> bug). I'll polish and post them next week. Once those are in I hope
>> we'll be able to enable the builtin "add -p" by default.
> 
> As this topic just hit master noticed (I apologize for not doing it
> sooner) the macOS problem (tested in 10.15.7) was gone (suspect fixed
> with 1/4) and therefore enabling the builtin by default as proposed
> originally by dscho could proceed without the additional series.

Thanks for testing this series

Best Wishes

Phillip