git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/3] mingw: remove unneeded `NO_CURL` directive

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 29, 2022, 15:41 UTC
Message-ID
<7dc0a1a9aa81fcd5c464c48995a61492fb97db1a.1659109272.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1306.v2.git.1659109272.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

In df5218b4c30 (config.mak.uname: support MSys2, 2016-01-13), we introduced support for building Git for Windows in the then-brand new Git for Windows v2.x build environment that was based off of MSYS2.

To do that, we split the non-msysGit part (that targeted MSys1) in two, and instead of sharing the `NO_CURL = YesPlease` setting with MSys1, we overrode it for MSYS2 with the empty value because we very much want to build Git for Windows with libcurl.

But that was unnecessary: we never set that variable beforehand, therefore there is no need to override it.

Let's just remove that unnecessary line.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 config.mak.uname | 1 -
 1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname
index e897b80b3a7..d63629fe807 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -719,7 +719,6 @@ else
 		HAVE_LIBCHARSET_H = YesPlease
 		USE_GETTEXT_SCHEME = fallthrough
 		USE_LIBPCRE = YesPlease
-		NO_CURL =
 		USE_NED_ALLOCATOR = YesPlease
 		ifeq (/mingw64,$(subst 32,64,$(prefix)))
 			# Move system config into top-level /etc/
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin
Message 9 of 12 in “mingw: include the Python parts in the build”
  1. mingw: include the Python parts in the buildJohannes Schindelin via GitGitGadget, Jul 28, 2022
  2. Junio C HamanoJul 28, 2022
  3. Johannes SchindelinJul 29, 2022
  4. Johannes SixtJul 29, 2022
  5. Johannes SchindelinAug 10, 2022
  6. 0/3 mingw: include the Python parts in the buildJohannes Schindelin via GitGitGadget, Jul 29, 2022
  7. 1/3 windows: include the Python bits when building Git for WindowsJohannes Schindelin via GitGitGadget, Jul 29, 2022
  8. 2/3 mingw: remove unneeded `NO_GETTEXT` directiveJohannes Schindelin via GitGitGadget, Jul 29, 2022
  9. 3/3 mingw: remove unneeded `NO_CURL` directiveJohannes Schindelin via GitGitGadget, Jul 29, 2022
  10. Johannes SchindelinJul 29, 2022
  11. Junio C HamanoJul 29, 2022
  12. Overriding creation factor in format-patch, was Re: [PATCH v2 0/3] mingw: include the Python parts in the buildJohannes Schindelin, Aug 10, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.