[PATCH v2 2/3] mingw: remove unneeded `NO_GETTEXT` directive
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Jul 29, 2022, 15:41 UTC
- Message-ID
- <019fb837d68fda459ff474f6763572461c7189a6.1659109272.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1306.v2.git.1659109272.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
In f9206ce2681 (mingw: let's use gettext with MSYS2, 2016-01-26), we flipped the switch to build Git for Windows with support for gettext.
However, the way we flipped the switch was by changing the value of the `NO_GETTEXT` variable from a non-empty string to the empty string, as if there was any `NO_GETTEXT` definition we needed to override.
But that was a mistake: while there _is_ a definition, it is in the `THIS_IS_MSYSGIT` section, i.e. it does not affect the Git for Windows part at all.
Let's just remove that unnecessary line.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- config.mak.uname | 1 - 1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname index fd7b6a90429..e897b80b3a7 100644 --- a/config.mak.uname +++ b/config.mak.uname @@ -717,7 +717,6 @@ else INSTALL = /bin/install INTERNAL_QSORT = YesPlease HAVE_LIBCHARSET_H = YesPlease - NO_GETTEXT = USE_GETTEXT_SCHEME = fallthrough USE_LIBPCRE = YesPlease NO_CURL =
-- gitgitgadget