git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/3] mingw: remove unneeded `NO_GETTEXT` directive

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 29, 2022, 15:41 UTC
Message-ID
<019fb837d68fda459ff474f6763572461c7189a6.1659109272.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1306.v2.git.1659109272.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

In f9206ce2681 (mingw: let's use gettext with MSYS2, 2016-01-26), we flipped the switch to build Git for Windows with support for gettext.

However, the way we flipped the switch was by changing the value of the `NO_GETTEXT` variable from a non-empty string to the empty string, as if there was any `NO_GETTEXT` definition we needed to override.

But that was a mistake: while there _is_ a definition, it is in the `THIS_IS_MSYSGIT` section, i.e. it does not affect the Git for Windows part at all.

Let's just remove that unnecessary line.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 config.mak.uname | 1 -
 1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname
index fd7b6a90429..e897b80b3a7 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -717,7 +717,6 @@ else
 		INSTALL = /bin/install
 		INTERNAL_QSORT = YesPlease
 		HAVE_LIBCHARSET_H = YesPlease
-		NO_GETTEXT =
 		USE_GETTEXT_SCHEME = fallthrough
 		USE_LIBPCRE = YesPlease
 		NO_CURL =
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin via GitGitGadget
Message 8 of 12 in “mingw: include the Python parts in the build”
  1. mingw: include the Python parts in the buildJohannes Schindelin via GitGitGadget, Jul 28, 2022
  2. Junio C HamanoJul 28, 2022
  3. Johannes SchindelinJul 29, 2022
  4. Johannes SixtJul 29, 2022
  5. Johannes SchindelinAug 10, 2022
  6. 0/3 mingw: include the Python parts in the buildJohannes Schindelin via GitGitGadget, Jul 29, 2022
  7. 1/3 windows: include the Python bits when building Git for WindowsJohannes Schindelin via GitGitGadget, Jul 29, 2022
  8. 2/3 mingw: remove unneeded `NO_GETTEXT` directiveJohannes Schindelin via GitGitGadget, Jul 29, 2022
  9. 3/3 mingw: remove unneeded `NO_CURL` directiveJohannes Schindelin via GitGitGadget, Jul 29, 2022
  10. Johannes SchindelinJul 29, 2022
  11. Junio C HamanoJul 29, 2022
  12. Overriding creation factor in format-patch, was Re: [PATCH v2 0/3] mingw: include the Python parts in the buildJohannes Schindelin, Aug 10, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.