Re: Weird behavior of 'git log --before' or 'git log --date-order': Commits from 2011 are treated to be before 1980
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Apr 18, 2023, 14:02 UTC
- Message-ID
- <7bbcfbc0-f9da-09ef-9441-5e4b13780841@github.com>
- In-Reply-To
- <20230418041253.GD60552@coredump.intra.peff.net>
On 4/18/2023 12:12 AM, Jeff King wrote:
> One thing the commit graph perhaps _could_ do is omit the commit, or > mark it as "this one is broken in some way". And then fall back to > parsing those few instead (which is slower, but if it's a small minority > of commits, that's OK). But I don't think there's any code for that.
The "broken" commit would need to be included in the commit-graph file so its children can point to it using a graph position, but then it would revert to parsing from the commit object (due to some new concept storing "this is a bad commit").
If we decided to treat a timestamp of 0 as "probably broken, artificial at best" then we wouldn't need the new indicator in the commit-graph file, but this seems like quite a big hammer for a small case.
Thanks, -Stolee