[PATCH 1/3] t4212: avoid putting git on left-hand side of pipe
- From
Jeff King <peff@peff.net>
- Date
- Apr 22, 2023, 13:42 UTC
- Message-ID
- <20230422134245.GA3942326@coredump.intra.peff.net>
- In-Reply-To
- <20230422134150.GA3516940@coredump.intra.peff.net>
We wouldn't expect cat-file to fail here, but it's good practice to avoid putting git on the upstream of a pipe, as we otherwise ignore its exit code.
Signed-off-by: Jeff King <peff@peff.net> --- t/t4212-log-corrupt.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t4212-log-corrupt.sh b/t/t4212-log-corrupt.sh index e89e1f54b6..8b5433ea74 100755 --- a/t/t4212-log-corrupt.sh +++ b/t/t4212-log-corrupt.sh @@ -8,8 +8,9 @@ TEST_PASSES_SANITIZE_LEAK=true test_expect_success 'setup' ' test_commit foo && - git cat-file commit HEAD | - sed "/^author /s/>/>-<>/" >broken_email.commit && + git cat-file commit HEAD >ok.commit && + sed "/^author /s/>/>-<>/" <ok.commit >broken_email.commit && + git hash-object --literally -w -t commit broken_email.commit >broken_email.hash && git update-ref refs/heads/broken_email $(cat broken_email.hash) '
-- 2.40.0.653.g15ca972062