Re: [PATCH v3 00/13] Optimization batch 11: avoid repeatedly detecting same renames

From: Derrick Stolee <stolee@gmail.com>
Date: May 22, 2021, 11:17 UTC
Message-ID: <7ac3d84e-d33f-5076-df9a-c91ece7a1265@gmail.com>
In-Reply-To: <pull.859.v3.git.1621490982.gitgitgadget@gmail.com>

On 5/20/21 2:09 AM, Elijah Newren via GitGitGadget wrote:

Show 9 quoted lines

> This series avoids repeatedly detecting the same renames in a sequence of
> merges such as a rebase or cherry-pick of several commits.
> 
> Changes since v2 (thanks to Stolee for the reviews!):
> 
>  * Patch 2: Wording cleanups (typo fixes and whatnot in the documentation)
>  * Patch 5: Expand the comment to explain the purpose of cached_irrelevant
>  * Patch 6: Add a cache_new_pairs() helper, remove extraneous line deletion
>  * Patch 7: Typo fix

Thanks. I'm happy with these changes.

> Not included: Additional trace2 metadata beyond that found in v2; I'm not
> sure what to record that would help (see
> https://lore.kernel.org/git/CABPp-BFdxn9f0-jUjY6Ake_6kX-jeN1EEzpeJeTg+TV4wfepwg@mail.gmail.com/)

Such a change could follow later, especially if we are diagnosing a tricky issue that comes up during early use. I commented on that message including my ideas about tracing, but they are optional.

Thanks, -Stolee