Re: [PATCH v2] Re: mailinfo: allow individual e-mail files as input

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Aug 7, 2009, 02:49 UTC
Message-ID: <7GvFnE4br-8WnXmtoea9V1LPY-qshCw6arPr6H40SRG59-b7YcpTsw@cipher.nrlssc.navy.mil>
In-Reply-To: <20090807023126.GH12924@vidovic>

Nicolas Sebrecht wrote:

Show 12 quoted lines

> The 06/08/09, Brandon Casey wrote:
>>                   I think it's a little strange like that though...
>>
>>    {
>>       sed "$1"
>>    } < "$1"
> 
> I'm not sure why this comment. The former
> 
>   sed "$1"
> 
> whithout anything else is enough.

The "former", or Junio's original patch, effectively has this form:

   {
      sed "$1"
   } < "$1"

Without reading closely enough, I thought it looked like this:

   {
      sed
   } < "$1"

Since I didn't study the sed statement closely enough, I assumed that it was operating on the remaining portion of the patch email that was redirected to the block on stdin. I missed the fact that the file name was supplied to it. My comment was that I found it strange (and maybe unintuitive, or maybe it's just me) that "$1" was piped on stdin and it was supplied as an argument to sed.

-brandon