Re: [PATCH 2/3] mailinfo: allow individual e-mail files as input

From: Jeff King <peff@peff.net>
Date: Aug 7, 2009, 01:18 UTC
Message-ID: <20090807011820.GA16472@coredump.intra.peff.net>
In-Reply-To: <COrzR9ThNBy5SQ7chsXyUB30jVGIijxZQ3LI9L_y7Ab5vWcDcy_HolvjjuHTC7DHI9ntV-eR_v0@cipher.nrlssc.navy.mil>

On Thu, Aug 06, 2009 at 08:08:12PM -0500, Brandon Casey wrote:

> You'll notice that I changed your grep -E to an egrep and dropped the -e.
> I do not see any other grep which uses -e, and I seem to recall Jeff King
> actively removing -e claiming that some greps do not recognize it.  I do not
> have a perfect memory though, so apologies to Jeff if I am mistaken.

Fortunately git does have a perfect memory:

  $ git log -1 --all-match --author=peff --grep=grep
  commit 759ad19e772a79a2a5ae6b7377d57eb21d29e6a0
  Author: Jeff King <peff@peff.net>
  Date:   Wed Oct 22 15:22:53 2008 -0400

      submodule: fix some non-portable grep invocations

      Not all greps support "-e", but in this case we can easily
      convert it to a single extended regex.

The grep in question is Solaris 8's /usr/bin/grep (which also needs "egrep" instead of "-E", as you already did).

-Peff