Re: [PATCH v12 00/10] convert: add support for different encodings
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Apr 3, 2018, 08:37 UTC
- Message-ID
- <7DE7FA3C-C2C9-491D-B51B-5E0C102C8261@gmail.com>
- In-Reply-To
- <3DC6237B-002F-4CAE-AD57-E10A5B5D3D3C@gmail.com>
Show 28 quoted lines
> On 02 Apr 2018, at 20:31, Lars Schneider <larsxschneider@gmail.com> wrote: > > >> On 29 Mar 2018, at 20:37, Junio C Hamano <gitster@pobox.com> wrote: >> >> lars.schneider@autodesk.com writes: >> >>> From: Lars Schneider <larsxschneider@gmail.com> >>> >>> Patches 1-6,9 are preparation and helper functions. Patch 4 is new. >>> Patch 7,8,10 are the actual change. >>> >>> This series depends on Torsten's 8462ff43e4 (convert_to_git(): >>> safe_crlf/checksafe becomes int conv_flags, 2018-01-13) which is >>> already in master. >> >> I didn't see any further review comments on this round, and as far >> as I can tell from my reading, these patches looked more-or-less >> ready. >> >> Except for 04/10 that had a few messages around "who should be >> responsible for handling the 'NULL is for the default UTF-8'?", that >> is. >> >> So, what's the doneness of this thing? > > Almost. I'll send a new round tomorrow. I hope to make this the final > round.
@Junio: Can you remind me of your preference? Should I rebase my series to 2.17.0 or keep the base to make it easier for you to check the interdiff?
Thanks, Lars