git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] convert: Stream from fd to required clean filter instead of mmap

From
Steffen Prohaska <prohaska@zib.de>
Date
Aug 19, 2014, 08:26 UTC
Message-ID
<7D3A2FB9-F1CA-470C-91CC-8FF28097F812@zib.de>
In-Reply-To
<20140819075345.GA7712@peff.net>
On Aug 19, 2014, at 9:53 AM, Jeff King <peff@peff.net> wrote:
Show 11 quoted lines
>>> For files >2GB on a 32-bit system (e.g. msysgit), filtering with the
>>> previous code always failed.  Now it works.  I created the patch to
>>> change git from 'fundamentally doesn't handle this' to 'works as
>>> expected'.
>> 
>> I deal with similar problem and added $GIT_ALLOC_LIMIT to test large
>> blob code. Maybe we could add $GIT_MMAP_LIMIT? I don't suppose we call
>> xmmap/xmalloc so often that the extra test would slow git down.
> 
> Yeah, I think I'd prefer that approach. We should mmap _way_ less than
> we malloc, and I do not think the malloc check has caused any problems.
I am going to update the patch accordingly.
	Steffen
Previous: Jeff King
Message 13 of 13 in “Stream fd to clean filter”
  1. 0/2 Stream fd to clean filterSteffen Prohaska, Aug 6, 2014
  2. 1/2 convert: Refactor would_convert_to_git() to single arg 'path'Steffen Prohaska, Aug 6, 2014
  3. 2/2 convert: Stream from fd to required clean filter instead of mmapSteffen Prohaska, Aug 6, 2014
  4. John KeepingAug 16, 2014
  5. Steffen ProhaskaAug 16, 2014
  6. Andreas SchwabAug 16, 2014
  7. Steffen ProhaskaAug 17, 2014
  8. Andreas SchwabAug 17, 2014
  9. Jeff KingAug 17, 2014
  10. Steffen ProhaskaAug 17, 2014
  11. Duy NguyenAug 17, 2014
  12. Jeff KingAug 19, 2014
  13. Steffen ProhaskaAug 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.