From: Steffen Prohaska <prohaska@zib.de>
Date: Tue, 19 Aug 2014 08:26:36 GMT
Subject: Re: [PATCH v2 2/2] convert: Stream from fd to required clean filter instead of mmap
Message-ID: <7D3A2FB9-F1CA-470C-91CC-8FF28097F812@zib.de>
In-Reply-To: <20140819075345.GA7712@peff.net>


On Aug 19, 2014, at 9:53 AM, Jeff King <peff@peff.net> wrote:

>>> For files >2GB on a 32-bit system (e.g. msysgit), filtering with the
>>> previous code always failed.  Now it works.  I created the patch to
>>> change git from 'fundamentally doesn't handle this' to 'works as
>>> expected'.
>> 
>> I deal with similar problem and added $GIT_ALLOC_LIMIT to test large
>> blob code. Maybe we could add $GIT_MMAP_LIMIT? I don't suppose we call
>> xmmap/xmalloc so often that the extra test would slow git down.
> 
> Yeah, I think I'd prefer that approach. We should mmap _way_ less than
> we malloc, and I do not think the malloc check has caused any problems.

I am going to update the patch accordingly.

	Steffen