Re: [BUG] Cloning with git HEAD fails for some repositories

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Mar 22, 2019, 18:41 UTC
Message-ID: <78963dea-9ac8-8fd3-c3cc-6237eee6f974@gmx.de>
In-Reply-To: <20190322180922.nghzdmvqz7wsxcb3@dcvr>

On 3/22/19 7:09 PM, Eric Wong wrote:

Show 35 quoted lines

> Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>> On 3/22/19 5:50 PM, Eric Wong wrote:
>>> I couldn't reproduce an error after porting your patch to
>>> master (commit 041f5ea1cf987a40 "The third batch"):
>>> https://80x24.org/spew/20190322163449.25362-1-e@80x24.org/raw
>>>
>>> So you might've hit an ephemeral error (bad connection,
>>> HTTP server restarting, etc).
>>>
>>> GIT_CURL_VERBOSE=1 git \
>>> 	-c http.maxRequests=1 -c http.followRedirects=true clone \
>>> 	http://git.denx.de/u-boot-efi.git
>>>
>>
>> I applied the patch to https://github.com/git/git origin/HEAD.
>>
>> But unfortunately it does not solve the issue:
>>
>> $ git --version
>> git version 2.21.0.197.g3845f293e6
>> $ git clone http://git.denx.de/u-boot-efi.git
>> Cloning into 'u-boot-efi'...
>> warning: alternate disabled by http.followRedirects:
>
> It looks like you need to enable http.followRedirects
> (see the command-line I used above)
>
>> http://git.denx.de/u-boot.git/
>> error: Unable to find a00d15757d7a513e410f15f2f910cb52333361a3 under
>> http://git.denx.de/u-boot-efi.git
>> Cannot obtain needed object a00d15757d7a513e410f15f2f910cb52333361a3
>> error: fetch failed.
>>
>> In Wireshark I see a lot of '404 Not found' codes.
>

Yes, git HEAD + said patch works with this command: git -c http.followRedirects=true clone http://git.denx.de/u-boot-efi.git

http.followRedirects is documented in man 1 git-config.

Why would git prior to 17966c0a63d25b1cc2dd1e98d30873e643bd581f~1 work without this redirect parameter?

That following redirects is not secure is already described in https://github.com/git/git/blob/master/Documentation/RelNotes/2.12.3.txt

Best regards

Heinrich