git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] Cloning with git HEAD fails for some repositories

From
Jeff King <peff@peff.net>
Date
Mar 23, 2019, 08:53 UTC
Message-ID
<20190323085341.GA9002@sigill.intra.peff.net>
In-Reply-To
<20190322165034.GA23124@dcvr>
On Fri, Mar 22, 2019 at 04:50:34PM +0000, Eric Wong wrote:
Show 11 quoted lines
> > Weird. I had set http.maxrequests to "1" to give more readable output
> > from GIT_CURL_VERBOSE, etc. It fails with that setting, but not with the
> > default of 5. Which certainly seems like a bug, but one that has been
> > there for a while (at least since v2.9.x, which I tested).
> 
> I couldn't reproduce an error after porting your patch to
> master (commit 041f5ea1cf987a40 "The third batch"):
> https://80x24.org/spew/20190322163449.25362-1-e@80x24.org/raw
> 
> So you might've hit an ephemeral error (bad connection,
> HTTP server restarting, etc).

No, it was quite reproducible. Curious, I decided to bisect. The problem started in ad75ebe5b3 (http: maintain curl sessions, 2009-11-27), but was later fixed by your 2abc848d54 (http: always remove curl easy from curlm session on release, 2016-09-13).

So trying to build the fix directly on 17966c0a63d (which is in between those) will run into this unrelated bug. But forward-porting does work.

-Peff
Previous: Eric WongNext: Jeff King
Message 10 of 14 in “[BUG] Cloning with git HEAD fails for some repositories”
  1. Heinrich SchuchardtMar 22, 2019
  2. Jeff KingMar 22, 2019
  3. Wolfgang DenkMar 22, 2019
  4. Jeff KingMar 22, 2019
  5. Eric WongMar 22, 2019
  6. Heinrich SchuchardtMar 22, 2019
  7. Eric WongMar 22, 2019
  8. Heinrich SchuchardtMar 22, 2019
  9. Eric WongMar 22, 2019
  10. Jeff KingMar 23, 2019
  11. 0/3 fix dumb-http fetch with alternatesJeff King, Mar 24, 2019
  12. 1/3 http: factor out curl result code normalizationJeff King, Mar 24, 2019
  13. 2/3 http: normalize curl results for dumb loose and alternates fetchesJeff King, Mar 24, 2019
  14. 3/3 http: use normalize_curl_result() instead of manual conversionJeff King, Mar 24, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.