Re: [PATCH v3] branch: introduce --show-current display option

From: Daniels Umanovskis <daniels@umanovskis.se>
Date: Oct 11, 2018, 23:31 UTC
Message-ID: <78139f32-0368-1c9e-52bc-4d5adf88aacd@umanovskis.se>
In-Reply-To: <xmqqva68dqip.fsf@gitster-ct.c.googlers.com>

On 10/12/18 1:15 AM, Junio C Hamano wrote:

Show 10 quoted lines

> It is a bit curious why you remove the branch but not the tag after
> this test.  [..]
> 
> So two equally valid choices are to remove "branch -d" and then
> either:
> 
>  (1) leave both branch and tag after this test in the test
>      repository
> 
>  (2) use test_when_finished [..]

Thanks for this explanation! You're right, I removed the branch because it otherwise breaks subsequent tests, while the tag doesn't matter. I'll go take a look at how test_when_finished can be used.

> Please do *not* cd around without being in a subshell.

Understood, thanks for explaining this as well.