Re: [PATCH v2 1/1] branch: introduce --show-current display option
On Thu, Oct 11, 2018 at 07:29:58PM +0200, Daniels Umanovskis wrote:
Show 8 quoted lines
> > Without passing the &flag argument, I do not think there is a
> > reliable way to ask resolve_ref_unsafe() if "HEAD" is a symbolic
> > ref.
>
> If I'm reading the code correctly, resolve_ref_unsafe() will return
> "HEAD" or NULL if there's no symbolic reference, so anything else would
> indicate a symref, but even in that case checking the flag explicitly is
> definitely better to clearly show intent.
Yes, that matches my understanding, too.
-Peff
Jeff King <peff@peff.net>