Re: [PATCH] git-stash: alias 'list' to 'ls' and 'clear' to 'rm'
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Feb 5, 2008, 12:12 UTC
- Message-ID
- <773F09A7-0871-4950-BDE4-D54E822C8203@wincent.com>
- In-Reply-To
- <20080205112000.GD29545@mail.stoakes.net>
El 5/2/2008, a las 12:20, Tim Stoakes escribió:
Show 18 quoted lines
> Wincent Colaiuta(win@wincent.com)@050208-12:06: >> El 5/2/2008, a las 11:38, Tim Stoakes escribi?: >> >>> clear:: >>> +rm:: >>> Remove all the stashed states. Note that those states will then >>> be subject to pruning, and may be difficult or impossible to >>> recover. >> >> Isn't "rm" a bit misleading here? Seeing as the clear subcommand >> really >> does an "rm -rf". > > $ git stash clear foo > git stash clear with parameters is unimplemented > > It appears that 'clear' is intended to behave like 'rm', however, it > isn't implemented yet.
No, I don't think it was ever _intended_ to behave like rm. It does pretty much what the man page says, clears all stashed states and that was always its intention.
But lots of people have said that they'd like to be able to pop only to topmost stash off the stack, or delete a specific stash, and some have reported being caught by surprise and clearing all stashes when they only wanted to delete one of them. There were patch(es) to the mailing list a while back teaching "git reflog" to delete specific entries, and seeing as "git stash" is built on top of reflogs the idea was that if someone wants to implement a subcommand for deleting specific stashes (or a push/pop kind of thing) then the reflog stuff would enable that. I think the refog patch(es) was/were from Dscho. I can't remember who/if has followed up with push/pop/delete patches for "git stash".
Cheers, Wincent