git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: diff attribute ignored by show and log -p

From
Jay Soffian <jaysoffian@gmail.com>
Date
Dec 17, 2009, 16:44 UTC
Message-ID
<76718490912170844i7d5f25d1hc32590b877dbf295@mail.gmail.com>
In-Reply-To
<20091217221740.6117@nanako3.lavabit.com>
On Thu, Dec 17, 2009 at 8:17 AM, Nanako Shiraishi <nanako3@lavabit.com> wrote:
Show 11 quoted lines
> Quoting Jay Soffian <jaysoffian@gmail.com>
>
>>> But is apparently ignored by "git log -p" and "git show" which just
>>> use internal diff. Is this behavior intentional?
>>
>> Ah, --ext-diff, and the reasoning behind requiring it for log/show is
>> explained in 72909be.
>
> The need to give --ext-diff is mentioned in 72909be (Add diff-option
> --ext-diff, 2007-06-30) but its log message doesn't 'explain' why external
> diff isn't used by default and you need to pass that extra option.

"To prevent funky games with external diff engines, git-log and friends prevent external diff engines from being called."

Seemed reason enough to me.
> Probably --ext-diff should be the default?
Or available via a config option anyway.
j.
Previous: Nanako ShiraishiNext: Jeff King
Message 4 of 5 in “diff attribute ignored by show and log -p”
  1. Jay SoffianDec 17, 2009
  2. Jay SoffianDec 17, 2009
  3. Nanako ShiraishiDec 17, 2009
  4. Jay SoffianDec 17, 2009
  5. Jeff KingDec 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.