From: Jay Soffian <jaysoffian@gmail.com>
Date: Thu, 17 Dec 2009 16:44:16 GMT
Subject: Re: diff attribute ignored by show and log -p
Message-ID: <76718490912170844i7d5f25d1hc32590b877dbf295@mail.gmail.com>
In-Reply-To: <20091217221740.6117@nanako3.lavabit.com>

On Thu, Dec 17, 2009 at 8:17 AM, Nanako Shiraishi <nanako3@lavabit.com> wrote:
> Quoting Jay Soffian <jaysoffian@gmail.com>
>
>>> But is apparently ignored by "git log -p" and "git show" which just
>>> use internal diff. Is this behavior intentional?
>>
>> Ah, --ext-diff, and the reasoning behind requiring it for log/show is
>> explained in 72909be.
>
> The need to give --ext-diff is mentioned in 72909be (Add diff-option
> --ext-diff, 2007-06-30) but its log message doesn't 'explain' why external
> diff isn't used by default and you need to pass that extra option.

"To prevent funky games with external diff engines, git-log and
friends prevent external diff engines from being called."

Seemed reason enough to me.

> Probably --ext-diff should be the default?

Or available via a config option anyway.

j.