git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 04/13] remote: make get_remote_ref_states() always populate states.tracked

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 24, 2009, 03:09 UTC
Message-ID
<76718490902231909n44b4ddebl1ce974090f90daff@mail.gmail.com>
In-Reply-To
<7vvdr0pqhp.fsf@gitster.siamese.dyndns.org>
On Mon, Feb 23, 2009 at 8:34 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Does this series _semantically_ depend on topics other than your other
> "set HEAD" topic that is still not in 'master'?

No, but I wanted Jeff's changes. I have checked that I can apply the "set HEAD" series, then Jeff's changes, then this latest series all to next w/o conflict.

I've not tried it w/o Jeff's changes in the middle.
Show 8 quoted lines
> I see you made it cleanly apply on top of 'pu', but frankly, I really hate
> to see a series based on 'pu' as a matter of principle and discipline.
>
> Other topics in 'pu' may not be ready for a long time, and you do not want
> this series to be taken hostage to them.  Having to fork your topic off of
> many other topics not even in 'next' means it would be more cumbersome for
> me to handle your series when any of the other topics that you base your
> work on need to be discarded or replaced.

Understood. I thought this situation was a little different though due to Jeff's changes in the middle which really build on my set HEAD topic.

Show 8 quoted lines
> In other words, you make your series unworkable with if you introduce too
> many dependencies.
>
> I've rebased it on top of Peff's jk/head-lookup topic (which in turn
> depends on your js/remote-set-head topic), but I suspect that you would
> want this series fork from and only depend on js/remote-set-head topic.
> In any case, please check the result after I push the results out to make
> sure that I did not make any silly mistakes while rebasing the series.
Will do, thanks.
> I also suspect that you would want to reroll the entire series anyway; see
> separate comments on 10/13 and 11/13.

I've replied to those. Would you mind applying 10/13 and 11/13 independently of this series? This topic depends on them since otherwise there will be double-frees, but they can go anywhere before the topic.

j.
Previous: Junio C HamanoNext: Jay Soffian
Message 7 of 38 in “New output style for git remote show”
  1. 00/13 New output style for git remote showJay Soffian, Feb 23, 2009
  2. 01/13 remote: rename variable and eliminate redundant function callJay Soffian, Feb 23, 2009
  3. 02/13 remote: remove unused code in get_ref_statesJay Soffian, Feb 23, 2009
  4. 03/13 remote: fix two inconsistencies in the output of "show <remote>"Jay Soffian, Feb 23, 2009
  5. 04/13 remote: make get_remote_ref_states() always populate states.trackedJay Soffian, Feb 23, 2009
  6. Junio C HamanoFeb 24, 2009
  7. Jay SoffianFeb 24, 2009
  8. Jay SoffianFeb 24, 2009
  9. 05/13 remote: name remote_refs consistentlyJay Soffian, Feb 23, 2009
  10. 06/13 string-list: new for_each_string_list() functionJay Soffian, Feb 23, 2009
  11. 07/13 remote: new show output styleJay Soffian, Feb 23, 2009
  12. Jeff KingFeb 23, 2009
  13. Marc BranchaudFeb 23, 2009
  14. 08/13 refactor duplicated get_local_heads() to remote.cJay Soffian, Feb 23, 2009
  15. 09/13 refactor duplicated ref_newer() to remote.cJay Soffian, Feb 23, 2009
  16. Jeff KingFeb 23, 2009
  17. 09/13 refactor duplicated ref_newer() to remote.cJay Soffian, Feb 23, 2009
  18. Johannes SixtFeb 23, 2009
  19. Jay SoffianFeb 23, 2009
  20. 10/13 remote.c: make match_refs() copy src ref before assigning to peer_refJay Soffian, Feb 23, 2009
  21. Junio C HamanoFeb 24, 2009
  22. Jay SoffianFeb 24, 2009
  23. Junio C HamanoFeb 24, 2009
  24. remote.c: make match_refs() copy src ref before assigning to peer_refJay Soffian, Feb 24, 2009
  25. Junio C HamanoFeb 24, 2009
  26. Jay SoffianFeb 24, 2009
  27. Junio C HamanoFeb 24, 2009
  28. 11/13 remote.c: don't short-circuit match_refs() when error in match_explicit_refs()Jay Soffian, Feb 23, 2009
  29. Junio C HamanoFeb 24, 2009
  30. Jay SoffianFeb 24, 2009
  31. 12/13 remote.c: refactor get_remote_ref_states()Jay Soffian, Feb 23, 2009
  32. Jeff KingFeb 23, 2009
  33. Jay SoffianFeb 23, 2009
  34. Jay SoffianFeb 23, 2009
  35. Jeff KingFeb 24, 2009
  36. 13/13 remote: new show output style for push refspecsJay Soffian, Feb 23, 2009
  37. Jeff KingFeb 23, 2009
  38. Jay SoffianFeb 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.