git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 12/13] remote.c: refactor get_remote_ref_states()

From
Jeff King <peff@peff.net>
Date
Feb 24, 2009, 01:05 UTC
Message-ID
<20090224010556.GA3847@coredump.intra.peff.net>
In-Reply-To
<1235377892-96089-1-git-send-email-jaysoffian@gmail.com>
On Mon, Feb 23, 2009 at 02:55:32AM -0500, Jay Soffian wrote:
> I see your hmph and raise you a hmph. :-)
> 
> Well, I _had_ tried as you suggested first, and thought it yuckier. It
> would actually be more like:

OK. My comment was along the lines of "why didn't you think of doing it this way first?" but apparently you did. ;)

> I'm not sure why passing a flag saying what you want is obfuscating.

It doesn't have to be. But from your description and my cursory look over the code, it seemed like get_remote_ref_states was really conflating several unrelated things. So breaking it apart would make sense for the same reason we have "strlen" and "strchr" as separate functions and not "string_ops(s, WANT_STRLEN)": the function is our basic unit of reusable work.

But from your description:
> caller1() {
>   setup_for_get();
>   get_thing_one();
> }

I didn't realize the commonality was actual setup; I thought it was "do a list of 5 things, but the first 2 are common, and then callers may want to some mix of the other 3".

So I think your original patch is fine.
-Peff
Previous: Jay SoffianNext: Jay Soffian
Message 35 of 38 in “New output style for git remote show”
  1. 00/13 New output style for git remote showJay Soffian, Feb 23, 2009
  2. 01/13 remote: rename variable and eliminate redundant function callJay Soffian, Feb 23, 2009
  3. 02/13 remote: remove unused code in get_ref_statesJay Soffian, Feb 23, 2009
  4. 03/13 remote: fix two inconsistencies in the output of "show <remote>"Jay Soffian, Feb 23, 2009
  5. 04/13 remote: make get_remote_ref_states() always populate states.trackedJay Soffian, Feb 23, 2009
  6. Junio C HamanoFeb 24, 2009
  7. Jay SoffianFeb 24, 2009
  8. Jay SoffianFeb 24, 2009
  9. 05/13 remote: name remote_refs consistentlyJay Soffian, Feb 23, 2009
  10. 06/13 string-list: new for_each_string_list() functionJay Soffian, Feb 23, 2009
  11. 07/13 remote: new show output styleJay Soffian, Feb 23, 2009
  12. Jeff KingFeb 23, 2009
  13. Marc BranchaudFeb 23, 2009
  14. 08/13 refactor duplicated get_local_heads() to remote.cJay Soffian, Feb 23, 2009
  15. 09/13 refactor duplicated ref_newer() to remote.cJay Soffian, Feb 23, 2009
  16. Jeff KingFeb 23, 2009
  17. 09/13 refactor duplicated ref_newer() to remote.cJay Soffian, Feb 23, 2009
  18. Johannes SixtFeb 23, 2009
  19. Jay SoffianFeb 23, 2009
  20. 10/13 remote.c: make match_refs() copy src ref before assigning to peer_refJay Soffian, Feb 23, 2009
  21. Junio C HamanoFeb 24, 2009
  22. Jay SoffianFeb 24, 2009
  23. Junio C HamanoFeb 24, 2009
  24. remote.c: make match_refs() copy src ref before assigning to peer_refJay Soffian, Feb 24, 2009
  25. Junio C HamanoFeb 24, 2009
  26. Jay SoffianFeb 24, 2009
  27. Junio C HamanoFeb 24, 2009
  28. 11/13 remote.c: don't short-circuit match_refs() when error in match_explicit_refs()Jay Soffian, Feb 23, 2009
  29. Junio C HamanoFeb 24, 2009
  30. Jay SoffianFeb 24, 2009
  31. 12/13 remote.c: refactor get_remote_ref_states()Jay Soffian, Feb 23, 2009
  32. Jeff KingFeb 23, 2009
  33. Jay SoffianFeb 23, 2009
  34. Jay SoffianFeb 23, 2009
  35. Jeff KingFeb 24, 2009
  36. 13/13 remote: new show output style for push refspecsJay Soffian, Feb 23, 2009
  37. Jeff KingFeb 23, 2009
  38. Jay SoffianFeb 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.