Re: [PATCH 4/4] builtin-remote: add set-head verb
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Feb 14, 2009, 02:48 UTC
- Message-ID
- <76718490902131848sb335b8bn2694c3e569aa1acd@mail.gmail.com>
- In-Reply-To
- <20090214021831.GB9907@coredump.intra.peff.net>
On Fri, Feb 13, 2009 at 9:18 PM, Jeff King <peff@peff.net> wrote:
Show 18 quoted lines
> Test #8 is just a matter of updating output. But #18 is explicitly about
> checking that "remote show" does not show symbolic refs. But Jay's patch
> is about explicitly showing symbolic refs (just doing so as a ref-name
> instead of a sha1):
>
> * FAIL 18: "remote show" does not show symbolic refs
> git clone one three &&
> (cd three &&
> git remote show origin > output &&
> ! grep HEAD < output &&
> ! grep -i stale < output)
>
> I guess we could tighten the grep to
>
> ! egrep "HEAD: [0-9a-f]{40}" < output
>
> but it may just make sense to get rid of the test; the exact output is
> already covered by test #8. Squashable patch is below.Thank you Jeff. I swear I ran t5505-remote.sh successfully but obviously I am misremembering.
j.