Re: [PATCH] builtin-remote: better handling of multiple remote HEADs

From: Jeff King <peff@peff.net>
Date: Feb 15, 2009, 06:08 UTC
Message-ID: <20090215060815.GA7473@coredump.intra.peff.net>
In-Reply-To: <20090214211548.GA14898@coredump.intra.peff.net>

On Sat, Feb 14, 2009 at 04:15:48PM -0500, Jeff King wrote:

Show 9 quoted lines

> On Sat, Feb 14, 2009 at 03:21:30PM -0500, Daniel Barkalow wrote:
> 
> > I haven't checked lately, but I think that what's actually needed is to 
> > have the locate_head() function notice if the struct ref for HEAD actually 
> > has the symref field non-NULL, and report that as the unambiguous answer. 
> 
> Indeed. Something like the patch below works (on top of Jay's patches).
> [...]
> I will try to make something a little neater later today.

Here is a cleaner series. It depends on all of Jay's remote patches, including the set-head one. I can resend once the dust is a little more settled on those patches.

The first two are prep for adding a test in 5/5:

   1/5: test scripts: refactor start_httpd helper
   2/5: add basic http clone/fetch tests

These ones are code cleanup for 5/5:

   3/5: refactor find_refs_by_name to accept const list
   4/5: remote: refactor guess_remote_head

And this is the useful one.

   5/5: remote: use exact HEAD lookup if it is available

-Peff