Re: [PATCH] builtin-branch: highlight current remote branches with an asterisk

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 10, 2009, 00:22 UTC
Message-ID: <76718490902091622y9a6d1bak5dc401858382e2ff@mail.gmail.com>
In-Reply-To: <20090210000321.78025483@crow>

(Please don't trim cc:)

On Mon, Feb 9, 2009 at 7:03 PM, Mark Burton <markb@ordern.com> wrote:

Show 7 quoted lines

> I don't know if I have any scripts that rely on a single star in front of
> the local HEAD or not (I'm sure some people must have them), but I do
> think this new feature would be very confusing, especially when used
> with -a.
>
> At the very least, make the indicator something other than a star, an @
> or #, perhaps.

With color, it shouldn't be confusing at all as only one branch is in green. W/o color, it still seems clear to me as the remote branches have their remote name prefixed to them. Even if you're on a detached head:

* (no branch)
  master
  next
  sent/branch-show-remote-HEAD
  wip/am-usability-improvements
  wip/push-docs
  origin/html
  origin/maint
  origin/man
* origin/master
  origin/next
  origin/pu
  origin/todo

A different marker doesn't really seem like an improvement to me:

* (no branch)
  master
  next
  sent/branch-show-remote-HEAD
  wip/am-usability-improvements
  wip/push-docs
  origin/html
  origin/maint
  origin/man
@ origin/master
  origin/next
  origin/pu
  origin/todo

But I'm happy to have the community paint the shed I've constructed.

j.