git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin

From
Jay Soffian <jaysoffian@gmail.com>
Date
Jan 28, 2009, 03:08 UTC
Message-ID
<76718490901271908m4f64232ka9cfb9c554589cf2@mail.gmail.com>
In-Reply-To
<7v7i4gyvzr.fsf@gitster.siamese.dyndns.org>
On Tue, Jan 27, 2009 at 10:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Jay Soffian <jaysoffian@gmail.com> writes:
>
>> Also ensure that $dotest is cleaned up if user manages to interupt mailsplit
>> while it is processing input.
>
> I do not think this "Also ensure" part is necessary nor desirable.  If
> something goes wrong, we'd like to have a way to resurrect some partial
> results from the split out result.

Hmm, git-am was already nuking $dotest if mailsplit exited non-zero, so I kept that behavior, but also clean-up if user kills git-am while mailsplit is running.

I still think it should nuke $dotest if user hits ctrl-c, but I agree if mailsplit exits non-zero it should not (which would be a change from what it does now).

> The rest looked fine.  Perhaps a re-roll?
Sure.
j.
Previous: Junio C Hamano
Message 5 of 5 in “git-am: emit usage when called w/o arguments and w/o patch on stdin”
  1. 1/2 git-am: emit usage when called w/o arguments and w/o patch on stdinJay Soffian, Jan 28, 2009
  2. 2/2 git-am: minor cleanupsJay Soffian, Jan 28, 2009
  3. Jay SoffianJan 28, 2009
  4. Junio C HamanoJan 28, 2009
  5. Jay SoffianJan 28, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.