From: Jay Soffian <jaysoffian@gmail.com>
Date: Wed, 28 Jan 2009 03:08:26 GMT
Subject: Re: [PATCH 1/2] git-am: emit usage when called w/o arguments and w/o patch on stdin
Message-ID: <76718490901271908m4f64232ka9cfb9c554589cf2@mail.gmail.com>
In-Reply-To: <7v7i4gyvzr.fsf@gitster.siamese.dyndns.org>

On Tue, Jan 27, 2009 at 10:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jay Soffian <jaysoffian@gmail.com> writes:
>
>> Also ensure that $dotest is cleaned up if user manages to interupt mailsplit
>> while it is processing input.
>
> I do not think this "Also ensure" part is necessary nor desirable.  If
> something goes wrong, we'd like to have a way to resurrect some partial
> results from the split out result.

Hmm, git-am was already nuking $dotest if mailsplit exited non-zero,
so I kept that behavior, but also clean-up if user kills git-am while
mailsplit is running.

I still think it should nuke $dotest if user hits ctrl-c, but I agree
if mailsplit exits non-zero it should not (which would be a change
from what it does now).

> The rest looked fine.  Perhaps a re-roll?

Sure.

j.