git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 16, 2008, 06:51 UTC
Message-ID
<76718490802152251x20102ecep383fb76ce0c96b64@mail.gmail.com>
In-Reply-To
<7vmyq1e86n.fsf@gitster.siamese.dyndns.org>
On Feb 16, 2008 1:17 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> "Jay Soffian" <jaysoffian@gmail.com> writes:
>
> > On Feb 15, 2008 6:24 PM, Junio C Hamano <gitster@pobox.com> wrote:
> >> Care to provide a test case for this one?
> >
> > I'll see what I can do. I'm not sure it makes a difference...
>
> Of course it does; otherwise I wouldn't have asked.

What I meant was, I wasn't sure if the output of mailinfo would have been incorrect w/o the patch. I noticed it only when I added the format=flowed code which relied on handle_filter() getting a single line at a time. I hadn't looked at whether handle_commit_msg() and/or handle_patch() (downstream of handle_filter) would care.

I wasn't trying to shirk off adding a test case. :-)
j.
Previous: Junio C Hamano
Message 8 of 8 in “mailinfo: ensure handle_filter gets only one line at a time”
  1. 1/3 mailinfo: ensure handle_filter gets only one line at a timeJay Soffian, Feb 15, 2008
  2. 2/3 mailinfo: support rfc3676 (format=flowed) text/plain messagesJay Soffian, Feb 15, 2008
  3. 3/3 test mailinfo rfc3676 supportJay Soffian, Feb 15, 2008
  4. Junio C HamanoFeb 15, 2008
  5. Jay SoffianFeb 15, 2008
  6. Junio C HamanoFeb 16, 2008
  7. Junio C HamanoFeb 16, 2008
  8. Jay SoffianFeb 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.