From: Jay Soffian Date: Sat, 16 Feb 2008 06:51:45 GMT Subject: Re: [PATCH 1/3] mailinfo: ensure handle_filter gets only one line at a time Message-ID: <76718490802152251x20102ecep383fb76ce0c96b64@mail.gmail.com> In-Reply-To: <7vmyq1e86n.fsf@gitster.siamese.dyndns.org> On Feb 16, 2008 1:17 AM, Junio C Hamano wrote: > "Jay Soffian" writes: > > > On Feb 15, 2008 6:24 PM, Junio C Hamano wrote: > >> Care to provide a test case for this one? > > > > I'll see what I can do. I'm not sure it makes a difference... > > Of course it does; otherwise I wouldn't have asked. What I meant was, I wasn't sure if the output of mailinfo would have been incorrect w/o the patch. I noticed it only when I added the format=flowed code which relied on handle_filter() getting a single line at a time. I hadn't looked at whether handle_commit_msg() and/or handle_patch() (downstream of handle_filter) would care. I wasn't trying to shirk off adding a test case. :-) j.