git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git p4 fix for failure to decode p4 errors

From
NSNikolay Shustov <nikolay.shustov@gmail.com>
Date
Apr 9, 2025, 12:20 UTC
Message-ID
<75b9457a-3da4-455d-9612-b83f25d3c854@gmail.com>
In-Reply-To
<CAFd+s4USsHPaepvfNtjm5VGieuH89zbW5Yj+OSXD8THxkj6tTw@mail.gmail.com>

Awesome, thanks! Could you please advise, what are my next steps to get this change accepted?

On 4/9/25 08:06, Fahad Al-Rashed wrote:
Show 79 quoted lines
> Hi Nikolay,
>
> Yes, the test passed.
>
> > ./t9837-git-p4-error-encoding.sh -v
>
> valid commands: submit, commit, sync, rebase, clone, branches, unshelve
>
> expecting success of 9837.1 'start p4d':
>
>         start_p4d
>
> waiting for p4d to start
>
> Perforce db files in '.' will be created if missing...
>
> Perforce server warning:
>
>         Pid 277404
>
>         Operation: topologyRegistration
>
>         No entries made in db.topology for server address: '9837', 
> dest address: '' and serverID: ''.
>
>         ServerID for the server should be set.
>
> User author saved.
>
> Client client saved.
>
> ok 1 - start p4d
>
> expecting success of 9837.2 'see if Perforce error with characters not 
> convertable to utf-8 will be processed correctly':
>
>         test_when_finished cleanup_git &&
>
> $python_target_binary "$TEST_DIRECTORY"/t9837/git-p4-error-python3.py 
> "$TEST_DIRECTORY"
>
> Could not decode value as utf-8; using configured fallback encoding 
> cp1252: b"Path '/xxx/git-git-p4-error-decoding/t/trash 
> directory.t9837-git-p4-error-encoding/\xfefile' is not under client's 
> root '/xxx/git-git-p4-error-decoding/t/trash 
> directory.t9837-git-p4-error-encoding/cli'.\n"
>
> (this warning is only displayed once during an import)
>
> ok 2 - see if Perforce error with characters not convertable to utf-8 
> will be processed correctly
>
> ./test-lib.sh: line 1007: 277399 Killed                  while true; do
>
>     if test $nr_tries_left -eq 0; then
>
>         kill -9 $p4d_pid; exit 1;
>
>     fi; sleep 1; nr_tries_left=$(($nr_tries_left - 1));
>
> done 2> /dev/null 4>&2
>
> # passed all 2 test(s)
>
> 1..2
>
>
> On Tue, Apr 8, 2025 at 3:13 PM Nikolay Shustov 
> <nikolay.shustov@gmail.com> wrote:
>
>     Hi Fahad,
>     I hope you are doing well.
>     If there are troubles with trying this on your Perforce system,
>     maybe we
>     could think of other way verifying the patch?
>
>     Thank you,
>     - Nikolay
>
Previous: Nikolay Shustov
Message 13 of 13 in “git p4 fix for failure to decode p4 errors”
  1. git p4 fix for failure to decode p4 errorsNikolay Shustov via GitGitGadget, Mar 20, 2025
  2. Nikolay ShustovMar 22, 2025
  3. Nikolay ShustovMar 25, 2025
  4. Phillip WoodMar 26, 2025
  5. Nikolay ShustovMar 30, 2025
  6. Nikolay ShustovMar 31, 2025
  7. Fahad Al-RashedMar 31, 2025
  8. Nikolay ShustovMar 31, 2025
  9. Nikolay ShustovApr 5, 2025
  10. Nikolay ShustovApr 8, 2025
  11. Phillip WoodApr 8, 2025
  12. Nikolay ShustovApr 8, 2025
  13. Nikolay ShustovApr 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.