From: Nikolay Shustov <nikolay.shustov@gmail.com>
Date: Wed, 09 Apr 2025 12:20:09 GMT
Subject: Re: [PATCH] git p4 fix for failure to decode p4 errors
Message-ID: <75b9457a-3da4-455d-9612-b83f25d3c854@gmail.com>
In-Reply-To: <CAFd+s4USsHPaepvfNtjm5VGieuH89zbW5Yj+OSXD8THxkj6tTw@mail.gmail.com>

Awesome, thanks!
Could you please advise, what are my next steps to get this change accepted?

On 4/9/25 08:06, Fahad Al-Rashed wrote:
> Hi Nikolay,
>
> Yes, the test passed.
>
> > ./t9837-git-p4-error-encoding.sh -v
>
> valid commands: submit, commit, sync, rebase, clone, branches, unshelve
>
> expecting success of 9837.1 'start p4d':
>
>         start_p4d
>
> waiting for p4d to start
>
> Perforce db files in '.' will be created if missing...
>
> Perforce server warning:
>
>         Pid 277404
>
>         Operation: topologyRegistration
>
>         No entries made in db.topology for server address: '9837', 
> dest address: '' and serverID: ''.
>
>         ServerID for the server should be set.
>
> User author saved.
>
> Client client saved.
>
> ok 1 - start p4d
>
> expecting success of 9837.2 'see if Perforce error with characters not 
> convertable to utf-8 will be processed correctly':
>
>         test_when_finished cleanup_git &&
>
> $python_target_binary "$TEST_DIRECTORY"/t9837/git-p4-error-python3.py 
> "$TEST_DIRECTORY"
>
> Could not decode value as utf-8; using configured fallback encoding 
> cp1252: b"Path '/xxx/git-git-p4-error-decoding/t/trash 
> directory.t9837-git-p4-error-encoding/\xfefile' is not under client's 
> root '/xxx/git-git-p4-error-decoding/t/trash 
> directory.t9837-git-p4-error-encoding/cli'.\n"
>
> (this warning is only displayed once during an import)
>
> ok 2 - see if Perforce error with characters not convertable to utf-8 
> will be processed correctly
>
> ./test-lib.sh: line 1007: 277399 Killed                  while true; do
>
>     if test $nr_tries_left -eq 0; then
>
>         kill -9 $p4d_pid; exit 1;
>
>     fi; sleep 1; nr_tries_left=$(($nr_tries_left - 1));
>
> done 2> /dev/null 4>&2
>
> # passed all 2 test(s)
>
> 1..2
>
>
> On Tue, Apr 8, 2025 at 3:13 PM Nikolay Shustov 
> <nikolay.shustov@gmail.com> wrote:
>
>     Hi Fahad,
>     I hope you are doing well.
>     If there are troubles with trying this on your Perforce system,
>     maybe we
>     could think of other way verifying the patch?
>
>     Thank you,
>     - Nikolay
>