git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Revert "git.el: Set process-environment instead of invoking env"

From
David Christensen <david@endpoint.com>
Date
Jun 3, 2008, 15:54 UTC
Message-ID
<7011F840-D6E2-4BB0-9538-601DA4DF54C3@endpoint.com>
In-Reply-To
<20080602223907.9612.84564.stgit@yoghurt>
Show 21 quoted lines
> This reverts commit dbe48256b41c1e94d81f2458d7e84b1fdcb47026, which
> caused mis-encoding of non-ASCII author/committer names when the
> git-status mode is used to create commits.
>
> Signed-off-by: Karl Hasselström <kha@treskal.com>
>
> ---
>
> On 2008-05-30 13:27:43 -0700, Junio C Hamano wrote:
>
>> Karl Hasselström <kha@treskal.com> writes:
>>
>>> How are things going with this fix? Junio, I expect you're waiting
>>> for a properly cleaned-up patch, possibly with acks from relevant
>>> people?
>>
>> You expected correctly.
>
> In case no one who understands how, why, and whether the fix works
> comes forward, here's a revert of the commit that introduced the
> problem.

This likely is due to the process-coding-system selected by emacs; the correct functioning of this command will rely on both the current buffer's coding system and the coding system of the data returned by the invocation of git-status. In order for this to function properly, these should match. Both of these are variables which can be customized local to the buffer as part of the routine, so this could be fixed if we are able to determine at invocation time what coding system the git-status command will return in (presumably some form of utf-8, but I believe this is configurable per repo).

I'd be glad to take a more in-depth look at this, but I'm not up on the code at this point.

Regards,

David -- David Christensen End Point Corporation david@endpoint.com

Previous: Karl Hasselström
Message 10 of 10 in “encoding bug in git.el”
  1. Karl HasselströmMay 20, 2008
  2. Clifford CaoileMay 21, 2008
  3. Karl HasselströmMay 21, 2008
  4. Clifford CaoileMay 21, 2008
  5. Karl HasselströmMay 23, 2008
  6. Karl HasselströmMay 25, 2008
  7. Karl HasselströmMay 30, 2008
  8. Junio C HamanoMay 30, 2008
  9. Revert "git.el: Set process-environment instead of invoking env"Karl Hasselström, Jun 2, 2008
  10. David ChristensenJun 3, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.