Re: encoding bug in git.el

From: Karl Hasselström <kha@treskal.com>
Date: May 30, 2008, 12:28 UTC
Message-ID: <20080530122826.GA4937@diana.vm.bytemark.co.uk>
In-Reply-To: <20080525134200.GA31990@diana.vm.bytemark.co.uk>

On 2008-05-25 15:42:00 +0200, Karl Hasselström wrote:

Show 13 quoted lines

> On 2008-05-21 23:08:09 +0900, Clifford Caoile wrote:
>
> > Here is a proposed fix.
>
> I don't claim to understand any of the design issues around this,
> but your patch certainly fixes my problem (once I managed to apply
> it, which involved working around the lack of headers, non-matching
> offsets, and whitespace damage -- luckily it was just two hunks).
> So:
>
> Tested-by: Karl Hasselström <kha@treskal.com>
>
> Thanks for taking the time.

How are things going with this fix? Junio, I expect you're waiting for a properly cleaned-up patch, possibly with acks from relevant people?

I think it would be a mistake to release 1.5.6 with this bug still in it; if not this bugfix, then a revert of the offending commit.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle