Re: [PATCH v3 2/3] t/: port helper/test-sha1.c to unit-tests/t-hash.c

From: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date: Jun 15, 2024, 20:14 UTC
Message-ID: <6fhpz4aqq7jr6ca2durig7e5a37g6ndzjjc2v46kjjkldohtja@tu7cdo4tu2r6>
In-Reply-To: <xmqqo78vnrba.fsf@gitster.g>

On Fri, 24 May 2024, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Christian Couder <christian.couder@gmail.com> writes:
> 
> >> Can we refactor this test to stop doing that? E.g., would it work if we
> >> used git-hash-object(1) to check that SHA1DC does its thing? Then we
> >> could get rid of the helper altogether, as far as I understand.
> >
> > It could perhaps work if we used git-hash-object(1) instead of
> > `test-tool sha1` in t0013-sha1dc to check that SHA1DC does its thing,
> > but we could do that in a separate patch or patch series.
> 
> Yeah, I think such a plan to make preliminary refactoring as a
> separate series, and then have another series to get rid of
> "test-tool sha1" (and "test-tool sha256" as well?) on top of it
> would work well.

It seems that git-hash-object does not die (or give an error) when providing t0013/shattered-1.pdf, and gives a different hash than the one explicitly mentioned t0013-sha1dc.sh. I suppose it is silently replacing the hash when it detects the collision. Is this an expected behaviour?

Thanks.