Re: [PATCH v3] json_writer: new routines to create data in JSON format

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mar 23, 2018, 19:33 UTC
Message-ID: <6b27b09b-727d-1c3f-c311-5cf6c9bafb4f@jeffhostetler.com>
In-Reply-To: <20180323171828.GD179915@aiede.svl.corp.google.com>

On 3/23/2018 1:18 PM, Jonathan Nieder wrote:

Show 15 quoted lines

> git@jeffhostetler.com wrote:
> 
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Add basic routines to generate data in JSON format.
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> 
> If I understand the cover letter correctly, this is a JSON-like
> format, not actual JSON.  Am I understanding correctly?
> 
> What are the requirements for consuming this output?  Will a typical
> JSON library be able to handle it without trouble?  If not, is there
> some subset of cases where a typical JSON library is able to handle it
> without trouble?

I'll add text to the commit message and the .h file explaining the Unicode limitation in the next reroll.

> 
> Can you say a little about the motivation here?  (I know you already
> put some of that in the cover letter, but since that doesn't become
> part of permanent history, it doesn't help the audience that matters.)

I'll add a note about that to the commit message. Thanks.

Show 7 quoted lines

> 
> This would also be easier to review if there were an application of it
> in the same series.  It's fine to send an RFC like this without such
> an application, but I think we should hold off on merging it until we
> have one.  Having an application makes review much easier since we can
> see how the API works in practice, how well the approach fits what
> users need, etc.

That's fine. I'm planning to push up another patch series next week that builds upon this, so hopefully that will help.

> 
> Thanks and hope that helps,
> Jonathan

Thanks, Jeff