Re: [PATCH v3] json_writer: new routines to create data in JSON format

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 23, 2018, 17:18 UTC
Message-ID: <20180323171828.GD179915@aiede.svl.corp.google.com>
In-Reply-To: <20180323162952.81443-2-git@jeffhostetler.com>

git@jeffhostetler.com wrote:

Show 5 quoted lines

> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Add basic routines to generate data in JSON format.
>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>

If I understand the cover letter correctly, this is a JSON-like format, not actual JSON. Am I understanding correctly?

What are the requirements for consuming this output? Will a typical JSON library be able to handle it without trouble? If not, is there some subset of cases where a typical JSON library is able to handle it without trouble?

Can you say a little about the motivation here? (I know you already put some of that in the cover letter, but since that doesn't become part of permanent history, it doesn't help the audience that matters.)

This would also be easier to review if there were an application of it in the same series. It's fine to send an RFC like this without such an application, but I think we should hold off on merging it until we have one. Having an application makes review much easier since we can see how the API works in practice, how well the approach fits what users need, etc.

Thanks and hope that helps, Jonathan